From aaef85ecbd558fec8aa138678fe859de930d42dd Mon Sep 17 00:00:00 2001 From: Sebastian Wick Date: Thu, 30 Oct 2025 11:43:19 +0100 Subject: [PATCH] brightnessManager: Propagate any attempted brightness change The BrightnessScale was trying to be smart by not notifying changes of its value when an action on it (stepUp, stepDown, cycleUp, set value) resulted in no change. It turns out that users do want to see an OSD even when their action resulted in no change. Always notify about attempted changes instead. Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/8770 Part-of: --- js/misc/brightnessManager.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/js/misc/brightnessManager.js b/js/misc/brightnessManager.js index 71f903763..eb4ad1b46 100644 --- a/js/misc/brightnessManager.js +++ b/js/misc/brightnessManager.js @@ -331,10 +331,7 @@ export const BrightnessScale = GObject.registerClass({ } _setValue(value) { - value = Math.clamp(value, 0.0, 1.0); - if (Math.abs(value - this._value) < SCALE_VALUE_CHANGE_EPSILON) - return; - this._value = value; + this._value = Math.clamp(value, 0.0, 1.0); this.notify('value'); } }); -- 2.39.5